Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to styled-components 5 #514

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

chore: upgrade to styled-components 5 #514

wants to merge 5 commits into from

Conversation

foot
Copy link
Contributor

@foot foot commented Mar 15, 2021

https://styled-components.com/docs/faqs#what-do-i-need-to-do-to-migrate-to-v5

fix: clicking on Code component

fix: react propType and dom attr warnings …

  • CircularProgress doesn't accept a number
  • hideCloseButtonActive missing in example
  • Use sc5 transient attributes ($loading) to avoid dom warnings when booleans writen to dom.
  • Update ({ fill: props => props.foo }) to
    (props => ({ fill: props.foo })) to fix fill warnings

@foot foot requested a review from jpellizzari March 15, 2021 17:16
Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foot I would expect some changes to the Code component around the animation errors we were seeing

@foot
Copy link
Contributor Author

foot commented Mar 16, 2021

I would expect some changes to the Code component around the animation errors we were seeing

Indeed! I assumed it was sc4/5 incompatibility but it seems quite broken in sc5. I'll TAL.

Also it would be cool to re-build the docs/examples for each PR..

@jpellizzari
Copy link
Contributor

Also it would be cool to re-build the docs/examples for each PR

Converting to netlify should be no problem

Indeed! I assumed it was sc4/5 incompatibility but it seems quite broken in sc5. I'll TAL.

It only happens onClick if I recall correctly.

- CircularProgress doesn't accept a number
- hideCloseButtonActive missing in example
- Use sc5 transient attributes ($loading) to avoid dom warnings
- Update ({ fill: props => props.foo }) to
  (props => ({ fill: props.foo })) to fix fill warnings
@foot foot requested a review from jpellizzari March 17, 2021 09:43
@foot
Copy link
Contributor Author

foot commented Mar 17, 2021

Sorry for the premature review request, tests still need some attention.

- To use react-test-renderer like the other tests
- Was a bit tricky to make shallow + withTheme play nice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants